[dpdk-dev] [PATCH 2/2] Move non-PCI related eth_dev initialization to rte_eth_dev_allocate()
Ferruh Yigit
ferruh.yigit at intel.com
Thu Nov 17 16:46:28 CET 2016
On 11/17/2016 2:24 PM, Jan Blunck wrote:
> This moves the non-PCI related initialization of the link state interrupt
> callback list and the setting of the default MTU to rte_eth_dev_allocate()
> so that drivers only need to set non-default values.
>
> Signed-off-by: Jan Blunck <jblunck at infradead.org>
> ---
> drivers/net/bonding/rte_eth_bond_api.c | 2 --
> drivers/net/cxgbe/cxgbe_main.c | 2 --
> drivers/net/mlx4/mlx4.c | 2 --
> drivers/net/mlx5/mlx5.c | 3 ---
> drivers/net/null/rte_eth_null.c | 2 --
> drivers/net/ring/rte_eth_ring.c | 2 --
> drivers/net/vhost/rte_eth_vhost.c | 2 --
> lib/librte_ether/rte_ethdev.c | 12 ++++--------
> 8 files changed, 4 insertions(+), 23 deletions(-)
I think following also redundant and can be removed:
app/test/virtual_pmd.c:
604: TAILQ_INIT(&(eth_dev->link_intr_cbs));
<...>
> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
> index 12af4b1..f58a995 100644
> --- a/lib/librte_ether/rte_ethdev.c
> +++ b/lib/librte_ether/rte_ethdev.c
What do you think doing same thing for rte_cryptodev.c J
> @@ -215,6 +215,10 @@ rte_eth_dev_allocate(const char *name)
> memset(eth_dev->data, 0, sizeof(*eth_dev->data));
> snprintf(eth_dev->data->name, sizeof(eth_dev->data->name), "%s", name);
> eth_dev->data->port_id = port_id;
> + eth_dev->data->rx_mbuf_alloc_failed = 0;
This is no more required, because of memset
> + eth_dev->data->mtu = ETHER_MTU;
> + TAILQ_INIT(&(eth_dev->link_intr_cbs));
> +
> eth_dev->attached = DEV_ATTACHED;
> eth_dev_last_created_port = port_id;
> nb_ports++;
> @@ -261,14 +265,6 @@ rte_eth_dev_pci_probe(struct rte_pci_driver *pci_drv,
> eth_dev->pci_dev = pci_dev;
> eth_dev->driver = eth_drv;
>
> - /* init user callbacks */
> - TAILQ_INIT(&(eth_dev->link_intr_cbs));
> -
> - /*
> - * Set the default MTU.
> - */
> - eth_dev->data->mtu = ETHER_MTU;
> -
> /* Invoke PMD device initialization function */
> diag = (*eth_drv->eth_dev_init)(eth_dev);
> if (diag == 0)
>
More information about the dev
mailing list