[dpdk-dev] [PATCH] mk: remove make target for examples
Thomas Monjalon
thomas.monjalon at 6wind.com
Tue Nov 22 10:38:39 CET 2016
2016-11-22 00:34, Ferruh Yigit:
> On 11/21/2016 11:47 PM, Thomas Monjalon wrote:
> > The command
> > make examples
> > works only if target directories have the exact name of configs.
> >
> > It is more flexible to use
> > make -C examples RTE_SDK=$(pwd) RTE_TARGET=build
> >
> > Signed-off-by: Thomas Monjalon <thomas.monjalon at 6wind.com>
>
> Instead of removing examples & examples_clean targets, what do you think
> keeping them as wrapper to suggested usage, for backward compatibility.
>
> Something like:
> "
> BUILDING_RTE_SDK :=
> export BUILDING_RTE_SDK
>
> # Build directory is given with O=
> O ?= $(RTE_SDK)/examples
>
> # Target for which examples should be built.
> T ?= build
>
> .PHONY: examples
> examples:
> @echo ================== Build examples for $(T)
> $(MAKE) -C examples O=$(abspath $(O)) RTE_TARGET=$(T);
>
> .PHONY: examples_clean
> examples_clean:
> @echo ================== Clean examples for $(T)
> $(MAKE) -C examples O=$(abspath $(O)) RTE_TARGET=$(T) clean;
> "
What is the benefit of this makefile? Just remove -C ?
It is not compatible with the old behaviour, so I'm afraid it would be
confusing for no real benefit.
More information about the dev
mailing list