[dpdk-dev] [PATCH 1/3] eal/drivers: prefix driver REGISTER macros with EAL

[Shreyansh Jain]

Hi David, Thomas,

On Friday 07 October 2016 07:03 PM, Shreyansh Jain wrote:
> DRIVER_REGISTER_PCI -> EAL_REGISTER_PCI
> DRIVER_REGISTER_PCI_TABLE -> EAL_REGISTER_PCI_TABLE
>
> Signed-off-by: Shreyansh Jain <shreyansh.jain at nxp.com>
> ---
>  doc/guides/prog_guide/dev_kit_build_system.rst | 2 +-
>  drivers/crypto/qat/rte_qat_cryptodev.c         | 4 ++--
>  drivers/net/bnx2x/bnx2x_ethdev.c               | 8 ++++----
>  drivers/net/bnxt/bnxt_ethdev.c                 | 4 ++--
>  drivers/net/cxgbe/cxgbe_ethdev.c               | 4 ++--
>  drivers/net/e1000/em_ethdev.c                  | 4 ++--
>  drivers/net/e1000/igb_ethdev.c                 | 8 ++++----
>  drivers/net/ena/ena_ethdev.c                   | 4 ++--
>  drivers/net/enic/enic_ethdev.c                 | 4 ++--
>  drivers/net/fm10k/fm10k_ethdev.c               | 4 ++--
>  drivers/net/i40e/i40e_ethdev.c                 | 4 ++--
>  drivers/net/i40e/i40e_ethdev_vf.c              | 4 ++--
>  drivers/net/ixgbe/ixgbe_ethdev.c               | 8 ++++----
>  drivers/net/mlx4/mlx4.c                        | 2 +-
>  drivers/net/mlx5/mlx5.c                        | 2 +-
>  drivers/net/nfp/nfp_net.c                      | 4 ++--
>  drivers/net/qede/qede_ethdev.c                 | 8 ++++----
>  drivers/net/szedata2/rte_eth_szedata2.c        | 4 ++--
>  drivers/net/thunderx/nicvf_ethdev.c            | 4 ++--
>  drivers/net/virtio/virtio_ethdev.c             | 2 +-
>  drivers/net/vmxnet3/vmxnet3_ethdev.c           | 4 ++--
>  lib/librte_eal/common/include/rte_dev.h        | 2 +-
>  lib/librte_eal/common/include/rte_pci.h        | 2 +-
>  23 files changed, 48 insertions(+), 48 deletions(-)
>
[...]

Ideally there should be a another patch like below as part of the series:

--->8---
diff --git a/mk/internal/rte.compile-pre.mk b/mk/internal/rte.compile-pre.mk
index a42ef03..a91c265 100644
--- a/mk/internal/rte.compile-pre.mk
+++ b/mk/internal/rte.compile-pre.mk
@@ -87,7 +87,7 @@ endif
  PMDINFO_GEN = $(RTE_SDK_BIN)/app/dpdk-pmdinfogen $@ $@.pmd.c
  PMDINFO_CC = $(CC) $(CPPFLAGS) $(CFLAGS) -c -o $@.pmd.o $@.pmd.c
  PMDINFO_LD = $(CROSS)ld $(LDFLAGS) -r -o $@.o $@.pmd.o $@
-PMDINFO_TO_O = if grep -q 'DRIVER_REGISTER_.*(.*)' $<; then \
+PMDINFO_TO_O = if grep 'EAL_REGISTER_.*(.*)' $<; then \
         echo "$(if $V,$(PMDINFO_GEN),  PMDINFO $@.pmd.c)" && \
         $(PMDINFO_GEN) && \
         echo "$(if $V,$(PMDINFO_CC),  CC $@.pmd.o)" && \

--->8---

But unfortunately, my build system complained about this. (and I stopped 
short of sending this patch).

The output of compilation after this patch is something like:

--->8---
   CC eal_pci_vfio.o
   PMDINFO eal_pci_vfio.o.pmd.c
/bin/sh: 1: 
/home/shreyansh/build/DPDK/02_dpdk/x86_64-native-linuxapp-gcc/app/dpdk-pmdinfogen: 
not found
/home/shreyansh/build/DPDK/02_dpdk/mk/internal/rte.compile-pre.mk:138: 
recipe for target 'eal_pci_vfio.o' failed
--->8---

I don't think PMDINFO should be running on eal_pci_vfio file. Isn't it? 
Is it because EAL_REGISTER_* is matching EAL_REGISTER_TAILQ like macro 
as well?

I am not very well versed with how PMDINFO is linking with the build 
system so any hints/insight into this would be really helpful.

One I get more clarity on this, I will push a new version of this patch.

-
Shreyansh