[dpdk-dev] [PATCH v2 4/7] vhost: add dequeue zero copy
Xu, Qian Q
qian.q.xu at intel.com
Mon Oct 10 12:12:52 CEST 2016
Good to know. I will try v3. BTW, on the master branch, seems vhost PMD is broken. When we run --vdev 'eth_vhost0,xxxx', then it will report the error that the driver is not supported. V16.07 is OK, but I haven't got time to do git bisect.
-----Original Message-----
From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com]
Sent: Sunday, October 9, 2016 3:03 AM
To: Xu, Qian Q <qian.q.xu at intel.com>
Cc: dev at dpdk.org; Maxime Coquelin <maxime.coquelin at redhat.com>
Subject: Re: [dpdk-dev] [PATCH v2 4/7] vhost: add dequeue zero copy
On Thu, Oct 06, 2016 at 02:37:27PM +0000, Xu, Qian Q wrote:
> this function copy_desc_to_mbuf has changed on the dpdk-next-virtio repo. Based on current dpdk-next-virtio repo, the commit ID is as below:
> commit b4f7b43cd9d3b6413f41221051d03a23bc5f5fbe
> Author: Zhiyong Yang <zhiyong.yang at intel.com>
> Date: Thu Sep 29 20:35:49 2016 +0800
>
> Then you will find the parameter "struct vhost_virtqueue *vq" is removed, so if apply your patch on that commit ID, the build will fail, since no vq definition but we used it in the function.
> Could you check? Thx.
I knew that: a rebase is needed, and I have done the rebase (locally); just haven't sent it out yet.
--yliu
>
> == Build lib/librte_table
> /home/qxu10/dpdk-zero/lib/librte_vhost/virtio_net.c: In function 'copy_desc_to_mbuf':
> /home/qxu10/dpdk-zero/lib/librte_vhost/virtio_net.c:745:21: error: 'vq' undeclared (first use in this function)
> zmbuf = get_zmbuf(vq);
> ^
> /home/qxu10/dpdk-zero/lib/librte_vhost/virtio_net.c:745:21: note: each
> undeclared identifier is reported only once for each function it
> appears in
> /home/qxu10/dpdk-zero/mk/internal/rte.compile-pre.mk:138: recipe for
> target 'virtio_net.o' failed
> make[5]: *** [virtio_net.o] Error 1
> /home/qxu10/dpdk-zero/mk/rte.subdir.mk:61: recipe for target
> 'librte_vhost' failed
> make[4]: *** [librte_vhost] Error 2
> make[4]: *** Waiting for unfinished jobs....
>
More information about the dev
mailing list