[dpdk-dev] [PATCH v7] net/virtio: add set_mtu in virtio

Kavanagh, Mark B mark.b.kavanagh at intel.com
Mon Oct 10 12:49:22 CEST 2016


>
>On Thu, Sep 29, 2016 at 04:31:30PM -0400, Dey wrote:
>>  /*
>>   * dev_ops for virtio, bare necessities for basic operation
>>   */
>> @@ -677,7 +685,6 @@ static const struct eth_dev_ops virtio_eth_dev_ops = {
>>  	.allmulticast_enable     = virtio_dev_allmulticast_enable,
>>  	.allmulticast_disable    = virtio_dev_allmulticast_disable,
>> +	.mtu_set                 = virtio_mtu_set,
>>  	.dev_infos_get           = virtio_dev_info_get,
>>  	.stats_get               = virtio_dev_stats_get,
>>  	.xstats_get              = virtio_dev_xstats_get,
>> --
>> 2.9.3.windows.1
>
>Your patch is malformed: I got an error while trying to apply it.
>
>    patch: **** malformed patch at line 167:   * dev_ops for virtio,
>    bare necessities for basic operation
>
>Seems like the way you were generating the patch is wrong.
>
>Anyway, I applied it manually, with the "- frame_size" fix as well
>as few more minor coding style fixes.
>
>So applied to dpdk-next-virtio.

Hi Yuanhan/Souvik,

Given my contributions to this patch (and in particular since comments from here - http://dpdk.org/ml/archives/dev/2016-September/047208.html - were copied directly into the commit message), I think that I should have been added as co-author of the patch? 

Let me know if you think that I am mistaken.

Thanks in advance,
Mark
>
>	--yliu


More information about the dev mailing list