[dpdk-dev] [PATCH] net/enic: update enic guide and add warning for invalid conf

Mcnamara, John john.mcnamara at intel.com
Mon Oct 10 16:16:09 CEST 2016


> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of John Daley
> Sent: Thursday, September 29, 2016 9:55 PM
> To: Richardson, Bruce <bruce.richardson at intel.com>
> Cc: dev at dpdk.org; Nelson Escobar <neescoba at cisco.com>
> Subject: [dpdk-dev] [PATCH] net/enic: update enic guide and add warning
> for invalid conf
> 
> From: Nelson Escobar <neescoba at cisco.com>
> 
> Update the enic guide to better explain how to setup vNIC parameters on
> the Cisco VIC since the introduction of rx scatter and print an error
> message for the case of having 1 RQ configured in the vNIC.
> 
> Signed-off-by: Nelson Escobar <neescoba at cisco.com>

Hi,

It would be better in the RST documentation to use ```` backticks to
designate function and variable names as fixed width. Also, the documentation
convention is to use Rx/Tx. However, these are minor so the patch is okay as
it is.

Acked-by: John McNamara <john.mcnamara at intel.com>





More information about the dev mailing list