[dpdk-dev] [PATCH v2 1/3] lib/librte_port: enable file descriptor port support

Thomas Monjalon thomas.monjalon at 6wind.com
Fri Oct 14 17:08:08 CEST 2016


2016-10-12 20:44, Dumitrescu, Cristian:
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> > This patchset was probably not tested as it does not compile.
> > And it could be useless if a TAP PMD is integrated.
> > I suggest to wait 17.02 cycle and see.
> 
> This patch was tested by me and Jasvinder as well and it works brilliantly.
> 
> We did not enable stats when testing, will sort out the missing semicolon issue in the stats macros and resend v3 asap. This is a trivial issue, no need to wait for 17.02.

So the stats were not tested.

> This is not conflicting with TAP PMD, and as said the scope of this supersedes the TAP PMD.

The v3 has been applied and it breaks FreeBSD compilation now.

I felt it was not ready but you won with the words "it works brilliantly" ;)
(sorry I have not resisted to make the joke)



More information about the dev mailing list