[dpdk-dev] [PATCH] net/bnx2x: fix icc build error

Bruce Richardson bruce.richardson at intel.com
Wed Oct 19 11:24:01 CEST 2016


On Mon, Oct 17, 2016 at 06:04:32PM +0000, Mody, Rasesh wrote:
> > From: Ferruh Yigit [mailto:ferruh.yigit at intel.com]
> > Sent: Monday, October 17, 2016 5:12 AM
> > 
> > On 9/30/2016 3:45 PM, Ferruh Yigit wrote:
> > > When bnx2x debug config enabled, icc (ICC) 17.0.0 20160721 gives the
> > > following compilation error:
> > >
> > > .../drivers/net/bnx2x/elink.c(6682):
> > > error #3656: variable "fw_ver1" may be used before its value is set
> > > 	PMD_DRV_LOG(DEBUG,
> > > 	^
> > >
> > > According logic in the code, this error is a false positive, but since
> > > this is not in the fast path, fixing compiler error by assigning
> > > initial value to variable.
> > >
> > > Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
<snip>
> 
> > Since this is an compilation fix, I believe it is good to have this in the release,
> > can you please review the patch?
> 
> Thanks!
> 
> Acked-by: Rasesh Mody <rasesh.mody at qlogic.com>
>  
Applied to dpdk-next-net/rel_16_11

/Bruce


More information about the dev mailing list