[dpdk-dev] [PATCH v4 04/32] net/qede/base: add HSI changes and register defines
Ferruh Yigit
ferruh.yigit at intel.com
Wed Oct 19 14:37:42 CEST 2016
On 10/19/2016 5:11 AM, Rasesh Mody wrote:
> - add the hardware software interface(HSI) changes
> - add register definitions
>
> These will be required for 8.10.9.0 FW upgrade.
>
> Signed-off-by: Rasesh Mody <rasesh.mody at qlogic.com>
<...>
> /*
> * Igu cleanup bit values to distinguish between clean or producer consumer
> */
> @@ -1376,7 +1572,7 @@ struct dmae_cmd {
> __le32 src_addr_hi;
> __le32 dst_addr_lo;
> __le32 dst_addr_hi;
> - __le16 length /* Length in DW */;
> + __le16 length_dw /* Length in DW */;
This cause a compilation error [1] in patch by patch compilation, when
debug is enabled. Fix seems straightforward [2].
Do you confirm the fix?
If you confirm, you don't need to send a new version, fix can be applied
while getting the patch.
Thanks,
ferruh
[1]:
====
In file included from .../drivers/net/qede/base/ecore.h:36:0,
from .../drivers/net/qede/base/ecore_hw.c:12:
.../drivers/net/qede/base/ecore_hw.c: In function ‘ecore_dmae_post_command’:
.../drivers/net/qede/base/ecore_hw.c:478:20: error: ‘struct dmae_cmd’
has no member named ‘length’; did you mean ‘length_dw’?
(int)p_command->length,
^
.../drivers/net/qede/base/../qede_logs.h:47:11: note: in definition of
macro ‘DP_VERBOSE’
##__VA_ARGS__); \
^~~~~~~~~~~
.../mk/internal/rte.compile-pre.mk:138: recipe for target
'base/ecore_hw.o' failed
[2]:
====
diff --git a/drivers/net/qede/base/ecore_hw.c
b/drivers/net/qede/base/ecore_hw.c
index 72bc6de..5412ed1 100644
--- a/drivers/net/qede/base/ecore_hw.c
+++ b/drivers/net/qede/base/ecore_hw.c
@@ -475,7 +475,7 @@ ecore_dmae_post_command(struct ecore_hwfn *p_hwfn,
struct ecore_ptt *p_ptt)
"len=0x%x src=0x%x:%x dst=0x%x:%x\n",
idx_cmd, (u32)p_command->opcode,
(u16)p_command->opcode_b,
- (int)p_command->length,
+ (int)p_command->length_dw,
(int)p_command->src_addr_hi,
(int)p_command->src_addr_lo,
(int)p_command->dst_addr_hi,
(int)p_command->dst_addr_lo);
More information about the dev
mailing list