[dpdk-dev] [PATCH] net/i40e: fix fdir configure failed issue in X710

Wu, Jingjing jingjing.wu at intel.com
Mon Oct 24 10:59:22 CEST 2016



> -----Original Message-----
> From: Guo, Jia
> Sent: Thursday, October 20, 2016 10:48 AM
> To: Zhang, Helin <helin.zhang at intel.com>; Wu, Jingjing <jingjing.wu at intel.com>
> Cc: dev at dpdk.org; Guo, Jia <jia.guo at intel.com>; Yigit, Ferruh <ferruh.yigit at intel.com>
> Subject: [PATCH] net/i40e: fix fdir configure failed issue in X710
> 
> The correct way to distinguish the behavior of X722 and X710
> or other NICs should be using the mac type but not X722 macro.
> 
The code change looks fine, but the commit log looks  Just don't know what the fdir configuration failure is.
Could you describe it in your commit log?
And a minor comment is like

I40E_RSS_HENA_ALL seems a part of I40E_RSS_HENA_ALL_X722, why not

#define I40E_RSS_HENA_ALL_ X722  I40E_RSS_HENA_ALL | I40E_FILTER_PCTYPE_XX

Thanks
Jingjing



More information about the dev mailing list