[dpdk-dev] [PATCH v4 07/32] net/qede: fix 32 bit compilation

[Thomas Monjalon]

2016-10-18 21:11, Rasesh Mody:
> Fix 32 bit compilation for gcc version 4.3.4.
> 
> Fixes: ec94dbc57362 ("qede: add base driver")
> 
> Signed-off-by: Rasesh Mody <rasesh.mody at qlogic.com>
[...]
>  ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y)
> +ifeq ($(shell gcc -Wno-unused-but-set-variable -Werror -E - < /dev/null > /dev/null 2>&1; echo $$?),0)
>  CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable
> +endif
>  CFLAGS_BASE_DRIVER += -Wno-missing-declarations
> +ifeq ($(shell gcc -Wno-maybe-uninitialized -Werror -E - < /dev/null > /dev/null 2>&1; echo $$?),0)
>  CFLAGS_BASE_DRIVER += -Wno-maybe-uninitialized
> +endif
>  CFLAGS_BASE_DRIVER += -Wno-strict-prototypes
>  ifeq ($(shell test $(GCC_VERSION) -ge 60 && echo 1), 1)
>  CFLAGS_BASE_DRIVER += -Wno-shift-negative-value

What the hell are you doing here?
1/ You should better fix "unused-but-set-variable" errors
2/ It won't work when cross-compiling because you do not use $(CC)
	in $(shell gcc

I really do not want to look at the qede patches.
But each time my eyes stop on one of them, I'm struggling.