[dpdk-dev] [PATCH 2/5] eal: extract function eal_parse_sysfs_valuef

Stephen Hemminger stephen at networkplumber.org
Thu Sep 1 08:30:10 CEST 2016


On Thu, 1 Sep 2016 10:11:52 +0530
Shreyansh Jain <shreyansh.jain at nxp.com> wrote:

> From: Jan Viktorin <viktorin at rehivetech.com>
> 
> From: Jan Viktorin <viktorin at rehivetech.com>
> 
> The eal_parse_sysfs_value function accepts a filename however, such
> interface introduces race-conditions to the code. Introduce the
> variant of this function that accepts an already opened file instead of
> a filename.
> 
> Signed-off-by: Jan Viktorin <viktorin at rehivetech.com>
> Signed-off-by: Shreyansh Jain <shreyansh.jain at nxp.com>
> ---

You introduce new API, but don't use it in your other patches.
I don't see where passing filename is racy. sysfs files only get created/destroyed
when device is added/removed.


More information about the dev mailing list