[dpdk-dev] [PATCH] virtio: remove obsolete comment

Matthias Gatto matthias.gatto at outscale.com
Mon Sep 5 11:18:15 CEST 2016


On Mon, Sep 5, 2016 at 4:25 AM, Yuanhan Liu <yuanhan.liu at linux.intel.com> wrote:
> On Fri, Sep 02, 2016 at 05:05:21PM +0200, Matthias Gatto wrote:
>> As new_device and destroy_device use an int instead of a "struct virtio_net *",
>> The comment about setting VIRTIO_DEV_RUNNING doesn't make sense anymore, plus
>> If I've correctly understand the code, the drivers take care of
>> setting the flag before calling the callbacks, so I guess that this comment
>> is obsolet and I've remove it.
>
> Yes, it is. The flag had been moved for internal use since commit
> 550c9d27d143 ("vhost: set/reset device flags internally").
>
> So, thanks and applied to dpdk-next-virtio.
>
>         --yliu

thanks for the review and for applied the patch.
Matthias


More information about the dev mailing list