[dpdk-dev] [PATCH v3 00/15] Introduce SoC device/driver framework for EAL

Hunt, David david.hunt at intel.com
Thu Sep 15 14:56:11 CEST 2016


Shreyansh, Jan, Hemant,

On 9/9/2016 9:43 AM, Shreyansh Jain wrote:
> Introduction:
> =============
>
> This patch set is direct derivative of Jan's original series [1],[2].
>
>   - As this deviates substantially from original series, if need be I can
>     post it as a separate patch rather than v2. Please suggest.
>   - Also, there are comments on original v1 ([4]) which are _not_
>     incorporated in this series as they refer to section no more in new
>     version.
>   - This v3 version is based on the rte_driver/device patchset v9 [10].
>     That series introduced device structures (rte_driver/rte_device)
>     generalizing devices into PCI, VDEV, XXX. For the purpose of this
>     patchset, XXX=>SOC.
>
>
---snip---

     FYI, I've reviewed this patch set, and it looks to me like there's 
some very good work here. Each patch in the set builds nicely on the one 
before, and logically introduces the changes one by one.

    I've no functional suggestions as the implementation looks clean, 
but I've one or two tiny suggestions on headers and error messages. I'll 
add a reply to the relevant patches in the set.

Also, there's one or two issues thrown up by checkpatch, but I suspect 
they're false positives, as I'm using the 4.6 kernel version.

Regards,
Dave




More information about the dev mailing list