[dpdk-dev] [PATCH] drivers: make driver names consistent
Thomas Monjalon
thomas.monjalon at 6wind.com
Fri Sep 16 11:58:09 CEST 2016
2016-08-24 22:37, Mcnamara, John:
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pablo de Lara
> >
> > ...
> >
> > - $RTE_TARGET/app/testpmd -c '0xf' -n 4 --vdev 'eth_pcap0,rx_pcap=/path/to/ file_rx.pcap,tx_pcap=/path/to/file_tx.pcap' -- --port-topology=chained
> > + $RTE_TARGET/app/testpmd -c '0xf' -n 4 --vdev 'net_pcap0,rx_pcap=/path/to/ file_rx.pcap,tx_pcap=/path/to/file_tx.pcap' -- --port-topology=chained
>
>
> I know that this is an existing issue but there shouldn't be a space in
> "/path/to/ file". Perhaps you could fix that (in a number of places) as part
> of this patch. You could probably leave out the "/path/to/" part altogether as
> it may be clearer, see below.
>
> Also, could you wrap the long code lines in the sections that you change at
> 80 chars using "\" to keep them on the page in the PDF docs, like:
>
> $RTE_TARGET/app/testpmd -c '0xf' -n 4 \
> --vdev 'net_pcap0,rx_pcap=/path/to/file_rx.pcap,tx_pcap=/path/to/file_tx.pcap' \
> -- --port-topology=chained
>
> Or without the path part:
>
> $RTE_TARGET/app/testpmd -c '0xf' -n 4 \
> --vdev 'net_pcap0,rx_pcap=file_rx.pcap,tx_pcap=file_tx.pcap' \
> -- --port-topology=chained
Applied with above comments fixed and release notes updated, thanks.
More information about the dev
mailing list