[dpdk-dev] [PATCH] hash: Correctly set the compare function.

De Lara Guarch, Pablo pablo.de.lara.guarch at intel.com
Wed Sep 21 23:30:35 CEST 2016



> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Wednesday, September 21, 2016 2:29 PM
> To: De Lara Guarch, Pablo
> Cc: dev at dpdk.org; Masoud Hasanifard
> Subject: Re: [dpdk-dev] [PATCH] hash: Correctly set the compare function.
> 
> 2016-09-19 18:36, De Lara Guarch, Pablo:
> > Commit titles start with lowercase ("correctly") and without a dot at the
> end.
> [...]
> > I think this is a fix, so probably it should contain the following "Fixes" line in
> the commit message:
> > Fixes: 95da2f8e9c61 ("hash: customize compare function")
> [...]
> > Good catch! Two comments inline.
> > Could you send a v2 with those two things added?
> 
> I can do these trivial changes when applying.
> Pablo, do you ack?

I do!



More information about the dev mailing list