[dpdk-dev] [PATCH v2 1/2] librte_ether: ensure not overwrite device data in mp app

[Thomas Monjalon]

2016-09-22 14:11, Kerlin, MarcinX:
> Hi Reshma,
> 
> From: Pattan, Reshma
> > 
> > Hi Marcin,
> > 
> > >  /**
> > >   * @internal
> > > + * Returns a shared device data slot specified by the unique identifier name.
> > > + *
> > > + * @param	name
> > > + *  The pointer to the Unique identifier name for each shared
> > > +Ethernet device
> > > + *  between multiple processes.
> > > + * @return
> > > + *   - The pointer to the device data slot, on success. NULL on error
> > > + */
> > > +struct rte_eth_dev_data *rte_eth_dev_data_allocated(const char
> > > +*name);
> > 
> > This should be static function in source file rather than public function.
> > And name can be rte_eth_dev_get_dev_by_name() something like that?
> 
> 1) Yes should be, this function is not using outside lib now, thanks
> 2) My proposition is rte_eth_dev_get_dev_data_by_name(), because it is related with device data structure.. Do you have any objections Thomas?

No objection on the name.
But the whole patch looks strange.

> I am waiting for still some objections and then prepare v3

Please could you better state the problem you want to solve in the
messages of each v3 patch?
I'll try to understand and review the v3.

Thanks