[dpdk-dev] [PATCH 1/2] i40e: Add packet_type metadata in the i40e vPMD

Zhang, Qi Z qi.z.zhang at intel.com
Mon Sep 26 03:46:19 CEST 2016



> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Friday, September 23, 2016 4:23 PM
> To: Zhang, Qi Z <qi.z.zhang at intel.com>
> Cc: dev at dpdk.org; Shaw, Jeffrey B <jeffrey.b.shaw at intel.com>; Zhang, Helin
> <helin.zhang at intel.com>; Wu, Jingjing <jingjing.wu at intel.com>
> Subject: Re: [dpdk-dev] [PATCH 1/2] i40e: Add packet_type metadata in the i40e
> vPMD
> 
> 2016-09-23 06:40, Zhang, Qi Z:
> > > From: Damjan Marion <damarion at cisco.com>
> > >
> > > The ptype is decoded from the rx descriptor and stored in the packet
> > > type field in the mbuf using the same function as the non-vector driver.
> > >
> > > Signed-off-by: Damjan Marion <damarion at cisco.com>
> > > Signed-off-by: Jeff Shaw <jeffrey.b.shaw at intel.com>
> >
> > Acted-by: Zhang Qi <qi.z.zhang at intel.com>
> 
> It should be Acked-by :)
> 
> Just a note about name convention:
> In DPDK we use the english naming style which is to put the first name first and
> the surname last.
> I believe your surname is Zhang so maybe you should write:
> 	Acked-by: Qi Zhang <qi.z.zhang at intel.com>
> 
> By the way, thanks for reviewing.

First time:)
Thanks!

Acked-by: Qi Zhang<qi.z.zhang at intel.com>


More information about the dev mailing list