[dpdk-dev] [PATCH 01/17] qede/base: update base driver

Ferruh Yigit ferruh.yigit at intel.com
Wed Sep 28 15:25:46 CEST 2016


On 9/16/2016 5:06 PM, Mody, Rasesh wrote:
> Hi Ferruh,
> 
>> From: Ferruh Yigit [mailto:ferruh.yigit at intel.com]
>> Sent: Friday, September 16, 2016 5:49 AM
>>
>> Hi Rasesh,
>>
>> On 8/27/2016 7:26 AM, Rasesh Mody wrote:
>>> This patch updates the base driver and incorporates neccessary changes
>>> required to bring in the new firmware 8.10.9.0.
>>>
>>> In addition, it would allow driver to add new functionalities that
>>> might be needed in future.
>>>
>>> Signed-off-by: Rasesh Mody <rasesh.mody at qlogic.com>
>>> ---
>> <...>
>>>  65 files changed, 14653 insertions(+), 8536 deletions(-)
>> <...>
>>
>> Sorry for late review.
>>
>> This is base driver update, but still a big single patch with 14K lines insertions,
>> it is too hard to both review or contribute.
>>
>> Is it possible to split patch into more smaller ones, ideally it should be one
>> patch for one feature/fix, but please do whatever can be done.
>>
>> I can see there are some big chunk of whitespace updates, or new files for
>> debug (hsi_debug_tools.h), those can be easy to target.
> 
> Thanks for reviewing, we'll send out v2 series. 

I just would like to remind that integration deadline is end of this
week: http://dpdk.org/dev/roadmap


> 
> Regards,
> Rasesh
> 
>> Thanks,
>> ferruh



More information about the dev mailing list