[dpdk-dev] [PATCH v2] app/test: remove large lpm test head file

[Dai, Wei]

> -----Original Message-----
> From: Richardson, Bruce
> Sent: Wednesday, September 28, 2016 4:42 PM
> To: Dai, Wei <wei.dai at intel.com>
> Cc: dev at dpdk.org
> Subject: Re: [PATCH v2] app/test: remove large lpm test head file
> 
> On Wed, Sep 28, 2016 at 01:38:27AM +0800, Wei Dai wrote:
> > remove the large file app/test/test_lpm_routes.h and add codes to
> > auto-generate similar large route rule talbe which keeps same depth
> > and IP class distribution as previous one in test_lpm_routes.h .
> > With the rule table auto-generated at run time, the performance of
> > looking up keep similar to that from pervious constant talbe.
> >
> > Signed-off-by: Wei Dai <wei.dai at intel.com>
> > ---
> 
> Can you perhaps indicate what has changed between v1 and v2, it helps those
> of us looking to review the patch. [The best way to do so is to place details of
> diffs in each version underneath the cut line "---".]

---
Changes between v2 and v1 include:
1. add more annotations to explain why and how the data structures and algorithm
  are designed.
2. simplify the implementation of same algorithm by removing fields total, left, abc[ ] 
  in struct route_rule_count. 

> 
> Regards,
> /Bruce