[dpdk-dev] [PATCH v8 2/2] net/vhost: add pmd xstats

Yang, Zhiyong zhiyong.yang at intel.com
Thu Sep 29 15:50:25 CEST 2016


Thanks very much,  yuanhan.

> -----Original Message-----
> From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com]
> Sent: Thursday, September 29, 2016 9:05 PM
> To: Yang, Zhiyong <zhiyong.yang at intel.com>
> Cc: dev at dpdk.org; Loftus, Ciara <ciara.loftus at intel.com>
> Subject: Re: [PATCH v8 2/2] net/vhost: add pmd xstats
> 
> On Thu, Sep 29, 2016 at 08:35:49PM +0800, Zhiyong Yang wrote:
> > This feature adds vhost pmd extended statistics from per port
> > perspective in order to meet the requirements of the applications such as
> OVS etc.
> > RX/TX xstats count the bytes without CRC. This is different from
> > physical NIC stats with CRC.
> ...
> > net/virtio pmd xstats(the function virtio_update_packet_stats) is used
> > as reference when implementing the feature.
> >
> > Thanks for the patches Zhiyong. I've tested the size stats and they
> > look good to me.
> 
> The above paragraph should not be in the commit log.
> 
> > Tested-by: Ciara Loftus <ciara.loftus at intel.com>
> >
> > Signed-off-by: Zhiyong Yang <zhiyong.yang at intel.com>
> 
> There should be no whitespace line bewteen the Tested-by and your SoB.
> 
> Fixed, and series applied to dpdk-next-virtio.
> 
> 	--yliu


More information about the dev mailing list