[dpdk-dev] [PATCH v6 0/3] clean up interrupt handle

Thomas Monjalon thomas.monjalon at 6wind.com
Wed Apr 5 18:41:13 CEST 2017


2017-04-05 07:09, Qi Zhang:
> It seems its not necessary to register an intr_handle for interrupt callback
> function. "void* cb_arg" shows enough when be used to pass the object that
> contain the information be required to handle the interrupt event( A typical
> way which is implemented by almost all driver is by passing a rte_ethdev
> instance).
> The patch change the prototype of rte_intr_callback_fn by removing
> the uncessary intr_handle paramter.

Pasting some comments from previous versions:

* You forgot to use --in-reply-to, so it is not convenient to check the history.

* Please keep the the prior acked-by in your patches if there are.
(if think there was a ack for vfio)

* The test patch should be squashed with eal/drivers changes.

New comment:

* New drivers has been added, please rebase and update them.



More information about the dev mailing list