[dpdk-dev] [PATCH v3 0/8] eal: dynamic logs

De Lara Guarch, Pablo pablo.de.lara.guarch at intel.com
Wed Apr 12 11:26:16 CEST 2017


Hi Olivier,

> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Olivier Matz
> Sent: Tuesday, April 04, 2017 5:41 PM
> To: dev at dpdk.org
> Cc: david.marchand at 6wind.com; Richardson, Bruce;
> thomas.monjalon at 6wind.com; Wiles, Keith;
> stephen at networkplumber.org
> Subject: [dpdk-dev] [PATCH v3 0/8] eal: dynamic logs
> 
> The objective of this patchset is to introduce a framework to
> support dynamic log types in EAL. It also provides one example of use
> (in i40e).
> 
> Features:
> - log types are identified by a string
> - at registration, a uniq identifier is associated to a log type
> - each log type can have its level changed dynamically
> - extend command line parameters to set the log level of a specific
>   type, or logs matching a regular expression
> - keep compat with other legacy types (eal, malloc, ring, user*,
>   etc... keep their hardcoded log type value)
> 
> Next step is to adapt drivers, libs and apps to use this new API. At the
> end, we can expect that all non-dataplane logs are moved to be dynamic,
> so we can enable/disable them at runtime, without recompiling. Many
> debug options can probably be removed from configuration:
>   $ git grep DEBUG config/common_base | wc -l
>   89
> 
> v2 -> v3:
> - fix compilation of intermediate patches
> - replace references to 17.02 by 17.05 (doc and .map)
> 
> v1 -> v2:
> - fix issues reported by Stephen
> - add entry in release note and deprecation notice
> - rebase on top of master
> 
> RFC -> v1:
> - rebase on top of current master
> - fix eal help alignment
> - remove unused i40e compilation options
> 
> 

With this patch, all logs that use logtype "USERX" (e.g.  RTE_LOGTYPE_USER1) are not shown anymore.
Should these macro be removed?

Right now, all applications using this won't show these, so I assume that all of them
should be fixed before the release is out.
Is that correct?

Thanks,
Pablo


More information about the dev mailing list