[dpdk-dev] [PATCH v1] lib/distributor: fix segfaults in flush
David Hunt
david.hunt at intel.com
Thu Apr 13 10:36:27 CEST 2017
A segfault when flushing packets has been revealed by further testing
when using distributor in single packet mode. This patch resolves that.
Fixes: 775003ad2f96 ("distributor: add new burst-capable library")
Reported-by: Yong Liu <yong.liu at intel.com>
Signed-off-by: David Hunt <david.hunt at intel.com>
---
lib/librte_distributor/rte_distributor.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/librte_distributor/rte_distributor.c b/lib/librte_distributor/rte_distributor.c
index 4725904..e4dfa7f 100644
--- a/lib/librte_distributor/rte_distributor.c
+++ b/lib/librte_distributor/rte_distributor.c
@@ -555,7 +555,7 @@ total_outstanding(const struct rte_distributor *d)
int
rte_distributor_flush_v1705(struct rte_distributor *d)
{
- const unsigned int flushed = total_outstanding(d);
+ unsigned int flushed;
unsigned int wkr;
if (d->alg_type == RTE_DIST_ALG_SINGLE) {
@@ -563,6 +563,8 @@ rte_distributor_flush_v1705(struct rte_distributor *d)
return rte_distributor_flush_v20(d->d_v20);
}
+ flushed = total_outstanding(d);
+
while (total_outstanding(d) > 0)
rte_distributor_process(d, NULL, 0);
@@ -590,6 +592,7 @@ rte_distributor_clear_returns_v1705(struct rte_distributor *d)
if (d->alg_type == RTE_DIST_ALG_SINGLE) {
/* Call the old API */
rte_distributor_clear_returns_v20(d->d_v20);
+ return;
}
/* throw away returns, so workers can exit */
--
2.7.4
More information about the dev
mailing list