[dpdk-dev] [PATCH] net/ixgbe: fix duplicated check

Zhao1, Wei wei.zhao1 at intel.com
Fri Apr 14 05:52:06 CEST 2017



> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Tuesday, April 11, 2017 11:21 PM
> To: Zhang, Helin <helin.zhang at intel.com>; Ananyev, Konstantin
> <konstantin.ananyev at intel.com>
> Cc: dev at dpdk.org; Yigit, Ferruh <ferruh.yigit at intel.com>; Lu, Wenzhuo
> <wenzhuo.lu at intel.com>; Zhao1, Wei <wei.zhao1 at intel.com>
> Subject: [PATCH] net/ixgbe: fix duplicated check
> 
> Same check duplicated, updated check according what commend states.
> 
> Coverity issue: 1407507
> Fixes: 11777435c727 ("net/ixgbe: parse flow director filter")
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
> ---
>  drivers/net/ixgbe/ixgbe_flow.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c
> index e2ba9c2..803d6f8 100644
> --- a/drivers/net/ixgbe/ixgbe_flow.c
> +++ b/drivers/net/ixgbe/ixgbe_flow.c
> @@ -2231,7 +2231,7 @@ ixgbe_parse_fdir_filter_tunnel(const struct
> rte_flow_attr *attr,
>  	index++;
>  	NEXT_ITEM_OF_PATTERN(item, pattern, index);
>  	if ((item->type != RTE_FLOW_ITEM_TYPE_VLAN) &&
> -		(item->type != RTE_FLOW_ITEM_TYPE_VLAN)) {
> +		(item->type != RTE_FLOW_ITEM_TYPE_IPV4)) {
>  		memset(rule, 0, sizeof(struct ixgbe_fdir_rule));
>  		rte_flow_error_set(error, EINVAL,
>  			RTE_FLOW_ERROR_TYPE_ITEM,
> --
> 2.9.3

Acked-by Wei Zhao<wei.zhao1 @intel.com>


More information about the dev mailing list