[dpdk-dev] [PATCH] event/sw: fix events mis-identified as needing reorder

Van Haaren, Harry harry.van.haaren at intel.com
Fri Apr 14 17:28:01 CEST 2017


> From: Richardson, Bruce
> Sent: Friday, April 14, 2017 4:18 PM
> To: Van Haaren, Harry <harry.van.haaren at intel.com>
> Cc: dev at dpdk.org; Richardson, Bruce <bruce.richardson at intel.com>
> Subject: [PATCH] event/sw: fix events mis-identified as needing reorder
> 
> When taking events from a port, we checked the history list to check if the
> event needed to be put back in order i.e. originally came from a reordered
> queue type. The check for reordering involved checking if the reorder
> buffer entry pointer was null. However, after that pointer was used it was
> never cleared to null again.
> 
> This caused problems when we had mixed reordered and atomic or parallel
> events, as the events from the latter two queue types were misidentified as
> needing reordering. This let in some cases to crashes, but mostly led to
> dropping events, and then application lock-up.
> 
> Fixes: 617995dfc5b2 ("event/sw: add scheduling logic")
> 
> Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>

+CC Thomas, would you pick this directly to master please, as no next-eventdev will be merged, thanks.

Acked-by: Harry van Haaren <harry.van.haaren at intel.com>


More information about the dev mailing list