[dpdk-dev] [PATCH 3/6] eal: remove log level from internal config

Ferruh Yigit ferruh.yigit at intel.com
Tue Apr 18 17:00:45 CEST 2017


On 4/18/2017 3:22 PM, Olivier Matz wrote:
> This field is only used in the initialization phase. Remove it since the
> global log level can also be retrieved using a public API:
> rte_log_get_global_level().
> 
> Signed-off-by: Olivier Matz <olivier.matz at 6wind.com>

<...>

> diff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/common/eal_common_log.c
> index dd4d30ca7..7d13cc026 100644
> --- a/lib/librte_eal/common/eal_common_log.c
> +++ b/lib/librte_eal/common/eal_common_log.c
> @@ -244,6 +244,12 @@ RTE_INIT(rte_log_init);
>  static void
>  rte_log_init(void)
>  {
> +#if RTE_LOG_LEVEL >= RTE_LOG_DEBUG

Why ">=" (I aware previous one is also like this :), setting global
config option to RTE_LOG_DEBUG cause a INFO level log...

> +	rte_log_set_global_level(RTE_LOG_INFO);
> +#else
> +	rte_log_set_global_level(RTE_LOG_LEVEL);
> +#endif



More information about the dev mailing list