[dpdk-dev] [PATCH 3/6] eal: remove log level from internal config

Olivier MATZ olivier.matz at 6wind.com
Tue Apr 18 17:26:19 CEST 2017


Hi Ferruh,

On Tue, 18 Apr 2017 16:00:45 +0100, Ferruh Yigit <ferruh.yigit at intel.com> wrote:
> On 4/18/2017 3:22 PM, Olivier Matz wrote:
> > This field is only used in the initialization phase. Remove it since the
> > global log level can also be retrieved using a public API:
> > rte_log_get_global_level().
> > 
> > Signed-off-by: Olivier Matz <olivier.matz at 6wind.com>  
> 
> <...>
> 
> > diff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/common/eal_common_log.c
> > index dd4d30ca7..7d13cc026 100644
> > --- a/lib/librte_eal/common/eal_common_log.c
> > +++ b/lib/librte_eal/common/eal_common_log.c
> > @@ -244,6 +244,12 @@ RTE_INIT(rte_log_init);
> >  static void
> >  rte_log_init(void)
> >  {
> > +#if RTE_LOG_LEVEL >= RTE_LOG_DEBUG  
> 
> Why ">=" (I aware previous one is also like this :), setting global
> config option to RTE_LOG_DEBUG cause a INFO level log...
> 
> > +	rte_log_set_global_level(RTE_LOG_INFO);
> > +#else
> > +	rte_log_set_global_level(RTE_LOG_LEVEL);
> > +#endif  
> 

From what I see, in the previous commit 9b9d7caa8414 ("log: increase default
level to info"), some code was added to prevent to set the default log
level to DEBUG, because it has an impact on performance.
    
But since commit 5d8f0baf69ea ("log: do not drop debug logs at compile time"),
the logs that impact performance should use RTE_LOG_DP().

I think this can be removed, and changed to:

 rte_log_set_global_level(RTE_LOG_LEVEL);


I did not do it in this patchset because I think it can wait next
version.



More information about the dev mailing list