[dpdk-dev] [PATCH v7 2/3] net/i40e: implement device reset on port

Thomas Monjalon thomas at monjalon.net
Thu Apr 20 23:20:13 CEST 2017


10/04/2017 05:02, Wei Zhao:
> +	memset(dev->data->dev_private, 0,
> +	       (uint64_t)&adapter->reset_flag - (uint64_t)adapter);

It does not compile for 32-bit.
Should it be replaced by offsetof()?

Does it mean that new fields should be added before reset_flag?
There is no comment about position importance of this field in the struct.
By the way, there is a field ptype_tbl appeared recently. Where should it
be positionned after rebase?


More information about the dev mailing list