[dpdk-dev] [PATCH v2] net/i40e: mbuf alloc failed counter not incremented

[Legacy, Allain]

> -----Original Message-----
> From: Ferruh Yigit [mailto:ferruh.yigit at intel.com]
> Sent: Monday, April 24, 2017 1:47 AM
<...>
> >  		nmb = rte_mbuf_raw_alloc(rxq->mp);
> > -		if (unlikely(!nmb))
> > +		if (unlikely(!nmb)) {
> > +			PMD_RX_LOG(DEBUG, "RX mbuf alloc failed
> port_id=%u "
> > +				   "queue_id=%u", (unsigned int)rxq-
> >port_id,
> > +				   (unsigned int)rxq->queue_id);
> 
> Do we really want debug print here?
> When you think the speeds we are dealing with, if mbuf alloc starts failing we
> may hit this lines millions per second, which may make app unusable?
> 
Sure, but isn't that the purpose of the PMD_RX_LOG/PMD_TX_LOG (i.e., to make it possible to log events in the rx/tx path when that becomes necessary)?  Presumably, this would be a debug option only when necessary during development and not used to debug an issue live while the application needs to be useable/responsive.