[dpdk-dev] [PATCH v2] app/testpmd: check port is stopped for QinQ setup

[Iremonger, Bernard]

Hi  Jingjing,

> -----Original Message-----
> From: Wu, Jingjing
> Sent: Tuesday, April 25, 2017 9:55 AM
> To: Iremonger, Bernard <bernard.iremonger at intel.com>; dev at dpdk.org
> Cc: Xing, Beilei <beilei.xing at intel.com>; Zhang, Qi <qi.zhang at intel.com>;
> Iremonger, Bernard <bernard.iremonger at intel.com>; stable at dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v2] app/testpmd: check port is stopped for
> QinQ setup
> 
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bernard
> Iremonger
> > Sent: Monday, April 24, 2017 6:25 PM
> > To: dev at dpdk.org
> > Cc: Xing, Beilei <beilei.xing at intel.com>; Zhang, Qi
> > <qi.zhang at intel.com>; Iremonger, Bernard
> > <bernard.iremonger at intel.com>; stable at dpdk.org
> > Subject: [dpdk-dev] [PATCH v2] app/testpmd: check port is stopped for
> > QinQ setup
> >
> > Check port is stopped before configuring it for QinQ, with the "vlan
> > set qinq on <port_id>" command.
> >
> > The above command sets the hw_vlan_extend flag.
> > When the port is started it calls the
> > i40e_rx_vec_dev_conf_condition_check_default function to decide
> > whether or not to select the vector mode driver depending on the state
> > of the hw_vlan_extend flag.
> >
> The command vlan set qinq on <port_id> is an common command, but not
> only For i40e. I think it's better to doc it somewhere instead of changing the
> default Behavior of this command.

There is a doc patch in flight:
http://dpdk.org/dev/patchwork/patch/23704/

Is this enough or should I send a v3 of this patch for the i40e PMD only?

Regards,

Bernard.