[dpdk-dev] [PATCH 1/2] net/ixgbe: remove a useless item type check

Zhao1, Wei wei.zhao1 at intel.com
Thu Apr 27 08:07:08 CEST 2017


Hi, wenzhuo

> -----Original Message-----
> From: Lu, Wenzhuo
> Sent: Friday, April 21, 2017 10:35 AM
> To: Zhao1, Wei <wei.zhao1 at intel.com>; dev at dpdk.org
> Cc: Zhao1, Wei <wei.zhao1 at intel.com>
> Subject: RE: [dpdk-dev] [PATCH 1/2] net/ixgbe: remove a useless item type
> check
> 
> Hi Wei,
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Wei Zhao
> > Sent: Thursday, April 20, 2017 11:28 AM
> > To: dev at dpdk.org
> > Cc: Zhao1, Wei
> > Subject: [dpdk-dev] [PATCH 1/2] net/ixgbe: remove a useless item type
> > check
> >
> > Remove a useless item type check for fdir flow rule.
> >
> > Fixes: 11777435c72 ("net/ixgbe: parse flow director filter")
> >
> > Signed-off-by: Wei Zhao <wei.zhao1 at intel.com>
> > ---
> >  drivers/net/ixgbe/ixgbe_flow.c | 9 +--------
> >  1 file changed, 1 insertion(+), 8 deletions(-)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_flow.c
> > b/drivers/net/ixgbe/ixgbe_flow.c index 7ce740e..11d8cc9 100644
> > --- a/drivers/net/ixgbe/ixgbe_flow.c
> > +++ b/drivers/net/ixgbe/ixgbe_flow.c
> > @@ -2346,16 +2346,9 @@ ixgbe_parse_fdir_filter_tunnel(const struct
> > rte_flow_attr *attr,
> >  				RTE_FLOW_ERROR_TYPE_ITEM,
> >  				item, "Not supported by fdir filter");
> >  			return -rte_errno;
> > -		} else if (item->type != RTE_FLOW_ITEM_TYPE_END) {
> > -			memset(rule, 0, sizeof(struct ixgbe_fdir_rule));
> > -			rte_flow_error_set(error, EINVAL,
> > -				RTE_FLOW_ERROR_TYPE_ITEM,
> > -				item, "Not supported by fdir filter");
> > -			return -rte_errno;
> >  		}
> Seems the item type only can be END. Why not remove  the VLAN check
> either?

Ok, I will commit a new v2 for this.

> 
> > +
> >  		/* check if the next not void item is END */
> > -		index++;
> > -		NEXT_ITEM_OF_PATTERN(item, pattern, index);
> >  		if (item->type != RTE_FLOW_ITEM_TYPE_END) {
> >  			memset(rule, 0, sizeof(struct ixgbe_fdir_rule));
> >  			rte_flow_error_set(error, EINVAL,
> > --
> > 2.9.3



More information about the dev mailing list