[dpdk-dev] [PATCH v2] app/testpmd: check port is stopped for QinQ setup

Iremonger, Bernard bernard.iremonger at intel.com
Thu Apr 27 10:11:20 CEST 2017


Hi Jingjing,

> -----Original Message-----
> From: Wu, Jingjing
> Sent: Thursday, April 27, 2017 6:28 AM
> To: Iremonger, Bernard <bernard.iremonger at intel.com>; dev at dpdk.org
> Cc: Xing, Beilei <beilei.xing at intel.com>; Zhang, Qi <qi.zhang at intel.com>;
> stable at dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v2] app/testpmd: check port is stopped for
> QinQ setup
> 
> 
> 
> > > The command vlan set qinq on <port_id> is an common command, but
> not
> > > only For i40e. I think it's better to doc it somewhere instead of
> > > changing the default Behavior of this command.
> >
> > There is a doc patch in flight:
> > http://dpdk.org/dev/patchwork/patch/23704/
> >
> > Is this enough or should I send a v3 of this patch for the i40e PMD only?
> >
> Yes. I think doc it is enough.
> We don't need this patch.
> 
> Thanks
> Jingjing


I will NAK this patch.

Self NAK

Regards,

Bernard.





More information about the dev mailing list