[dpdk-dev] [dpdk-maintainers] Example(Load_balancer) Tx Flush Bug(This bug DPDK each version)

[Andriy Berestovskyy]

Hey,
Those patches superseded by:
http://dpdk.org/ml/archives/dev/2017-April/064858.html

Regards,
Andriy


On Mon, Jan 16, 2017 at 3:18 PM, Thomas Monjalon
<thomas.monjalon at 6wind.com> wrote:
> Hi,
>
> Sorry if you feel your patch is ignored.
> It is not in the right format for several reasons we tried
> to explain earlier I think.
> Please read carefully this doc:
>         http://dpdk.org/doc/guides/contributing/patches.html
>
>
> 2017-01-16 19:16, Maple:
>> From: Maple <liujian at raisecom.com>
>> To: <qiming.yang at intel.com>;<dev at dpdk.org>
>> Cc: <maintainers at dpdk.org>
>> Subject: [PATCH] Load_balancer Tx Flush Bug
>> Date: Mon, 16 Dec 2017 19:15:48 +0800
>> Message-Id: <1482371868-19669-1-git-send-email-liujian at raisecom.com>
>> X-Mailer: git-send-email 1.9.1
>> In-Reply-To: <2016122122394164225248 at raisecom.com>
>> References: <2016122122394164225248 at raisecom.com>
>>
>> We found a bug in use load_balancer example,and,This bug DPDK each version.
>> In IO tx flush, only flush port 0.
>> So,If I enable more than the Port,then,In addition to 0 port won't flush.
>>
>> Signed-off-by: Maple <liujian at raisecom.com>
>> ---
>>  a/examples/load_balancer/runtime.c | 667 ++++++++++++++++++++++++++++++++++++
>>  b/examples/load_balancer/runtime.c | 669 +++++++++++++++++++++++++++++++++++++
>>  2 files changed, 1336 insertions(+)
>>  create mode 100644 a/examples/load_balancer/runtime.c
>>  create mode 100644 b/examples/load_balancer/runtime.c
>>
>> diff --git a/examples/load_balancer/runtime.c b/examples/load_balancer/runtime.c
>> index 9612392..3a2e900 100644
>> --- a/test/a/examples/load_balancer/runtime.c
>> +++ b/test/b/examples/load_balancer/runtime.c
>> @@ -418,9 +418,11 @@ app_lcore_io_tx(
>>  static inline void
>>  app_lcore_io_tx_flush(struct app_lcore_params_io *lp)
>>  {
>> +       uint8_t i;
>>         uint8_t port;
>>
>> -       for (port = 0; port < lp->tx.n_nic_ports; port ++) {
>> +       port = lp->tx.nic_ports[0];
>> +       for (i = 0; i < lp->tx.n_nic_ports; i ++) {
>>                 uint32_t n_pkts;
>>
>>                 if (likely((lp->tx.mbuf_out_flush[port] == 0) ||
>>
>
>



-- 
Andriy Berestovskyy