[dpdk-dev] [PATCH] doc: add author on cc to git fixline alias

Mcnamara, John john.mcnamara at intel.com
Thu Aug 3 12:55:44 CEST 2017



> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Harry van Haaren
> Sent: Wednesday, July 12, 2017 2:39 PM
> To: dev at dpdk.org
> Cc: thomas at monjalon.net; Van Haaren, Harry <harry.van.haaren at intel.com>
> Subject: [dpdk-dev] [PATCH] doc: add author on cc to git fixline alias
> 
> With this commit, the correct method to use git fixline to indicate a fix
> of a previous commit has changed. The new rules require the author of the
> original code that is being fixed to be on CC.
> 
> The logic behind this improvement is that if there is a genuine bug, one
> of the ideal people to review is the author of the original code being
> fixed. Adding them on Cc makes them aware of the patch, avoiding it from
> being passed by accidentally while reading the mailing-list.
> 
> Given that the original author (now on Cc:) might not actually review,
> there is no value in keeping the Cc: in git commit history. If the
> original author performs a review, their Reviewed-by: or Acked-by: is
> stored in git history (same as now).
> 
> Signed-off-by: Harry van Haaren <harry.van.haaren at intel.com>

Acked-by: John McNamara <john.mcnamara at intel.com>





More information about the dev mailing list