[dpdk-dev] [PATCH v2] doc: add prog_guide for the GRO library

Mcnamara, John john.mcnamara at intel.com
Fri Aug 4 11:11:18 CEST 2017


> -----Original Message-----
> From: Hu, Jiayu
> Sent: Friday, August 4, 2017 9:21 AM
> To: dev at dpdk.org
> Cc: thomas at monjalon.net; Mcnamara, John <john.mcnamara at intel.com>; Hu,
> Jiayu <jiayu.hu at intel.com>
> Subject: [PATCH v2] doc: add prog_guide for the GRO library
> 
> Add prog_guide doc to explain the design of the GRO library.

> ...

> +Generic Receive Offload Library
> +===============================
> +
> ...
> +
> +The GRO library assumes all inputted packets are with correct checksums.
> +In addition, the GRO library doesn't re-calculate checksums for merged
> +packets. If inputted packets are IP fragmented, the GRO library assumes
> +they are complete packets (i.e. with L4 headers).

It is more correct/common to use input instead of inputted. You should
make this change throughout the doc.

Also this bout be better as:

The GRO library assumes all input packets have correct checksums. In addition, the GRO library doesn't re-calculate checksums for merged packets.

Apart from that:

Acked-by: John McNamara <john.mcnamara at intel.com>


More information about the dev mailing list