[dpdk-dev] [PATCH] eventdev: fix missing includes
Thomas Monjalon
thomas at monjalon.net
Fri Aug 4 12:44:32 CEST 2017
04/08/2017 12:35, Jerin Jacob:
> -----Original Message-----
> > Date: Fri, 4 Aug 2017 12:20:35 +0200
> > From: Thomas Monjalon <thomas at monjalon.net>
> > To: jerin.jacob at caviumnetworks.com
> > Cc: dev at dpdk.org
> > Subject: [PATCH] eventdev: fix missing includes
> > X-Mailer: git-send-email 2.13.2
> >
> > The PCI helper file depends on some EAL definitions.
> > Spotted with devtools/check-includes.sh:
> > error: implicit declaration of function ‘rte_eal_process_type’
> > error: ‘RTE_PROC_PRIMARY’ undeclared
> > error: implicit declaration of function ‘rte_socket_id’
> >
> > There was also this error because the inline keyword was missing:
> > error: ‘rte_event_pmd_pci_probe’ defined but not used
> >
> > Fixes: 9a8269d56942 ("eventdev: make PCI probe and remove functions optional")
> >
> > Signed-off-by: Thomas Monjalon <thomas at monjalon.net>
> > ---
> > lib/Makefile | 2 +-
> > lib/librte_eventdev/rte_eventdev_pmd_pci.h | 4 +++-
> > 2 files changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/lib/Makefile b/lib/Makefile
> > index 86caba17b..22962910d 100644
> > --- a/lib/Makefile
> > +++ b/lib/Makefile
> > @@ -69,7 +69,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_IP_FRAG) += librte_ip_frag
> > DEPDIRS-librte_ip_frag := librte_eal librte_mempool librte_mbuf librte_ether
> > DEPDIRS-librte_ip_frag += librte_hash
> > DIRS-$(CONFIG_RTE_LIBRTE_GRO) += librte_gro
> > -DEPDIRS-librte_gro := librte_eal librte_mbuf librte_ether librte_net
> > +DEPDIRS-librte_gro := librte_eal librte_mbuf
>
> Looks like unrelated change. Right?
Yes you're right.
I wanted to remove this wrong part of the patch and forgot.
Will send a v2, thanks
More information about the dev
mailing list