[dpdk-dev] [PATCH] doc: API change notice for librte_meter

Dumitrescu, Cristian cristian.dumitrescu at intel.com
Fri Aug 4 16:38:45 CEST 2017



> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas at monjalon.net]
> Sent: Friday, August 4, 2017 3:29 PM
> To: Dumitrescu, Cristian <cristian.dumitrescu at intel.com>; Horton, Remy
> <remy.horton at intel.com>
> Cc: dev at dpdk.org; Mcnamara, John <john.mcnamara at intel.com>; Singh,
> Jasvinder <jasvinder.singh at intel.com>; Nicolau, Radu
> <radu.nicolau at intel.com>; Hunt, David <david.hunt at intel.com>
> Subject: Re: [PATCH] doc: API change notice for librte_meter
> 
> 04/08/2017 15:19, Cristian Dumitrescu:
> > +* librte_meter: The API will change to accommodate configuration
> profiles.
> > +  Most of the API functions will have an additional opaque parameter.
> 
> Why?
> Why opaque parameter?
> If you want to use it with a configuration file, you just have to
> implement a configuration file in your application.
> 
> Moreover, I already explained my fear of adding this library in DPDK
> which is really an application-level statistics lib.
> 
> Without more explanations, my vote is a nack.
> 
> However I remember there was a promise to merge every metrics libs in
> one.

Thomas,

Confusion with librte_metrics, which is a totally different library? This is about librte_meter, nothing to do with stats/metrics.

This librte_meter is doing traffic metering, essentially the computing the packet color according to the IETF RFCs 2697 (srTCM = Single Rate Three Color Marker) and 2698 (trTCM = Two Rate Three Color Marker). This is a fundamental block for pretty much every edge router upstream path.

You asked me on numerous occasions to be concise, so here is a concise deprecation notice. I have to say initially I wrote a more laborious one, then I remembered your advice and cut it down to this version. Do you need more details on the motivation?

Regards,
Cristian




More information about the dev mailing list