[dpdk-dev] [PATCH] net/failsafe: safer subdev iterator

Gaetan Rivet gaetan.rivet at 6wind.com
Thu Aug 17 17:52:09 CEST 2017


The sub_device iterator macro should follow the general gist of the
tailq API for an easier understanding and safer use.

Once the loop has finished, the iterator should be set to NULL.
If no sub_device was iterated upon, the iterator should still be NULL.

Signed-off-by: Gaetan Rivet <gaetan.rivet at 6wind.com>
---
 drivers/net/failsafe/failsafe_private.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/failsafe/failsafe_private.h b/drivers/net/failsafe/failsafe_private.h
index 0361cf4..6fa8de5 100644
--- a/drivers/net/failsafe/failsafe_private.h
+++ b/drivers/net/failsafe/failsafe_private.h
@@ -222,6 +222,7 @@ extern int mac_from_arg;
  */
 #define FOREACH_SUBDEV_STATE(s, i, dev, state)				\
 	for (i = fs_find_next((dev), 0, state);				\
+	     ((s = NULL) == NULL) &&					\
 	     i < PRIV(dev)->subs_tail && (s = &PRIV(dev)->subs[i]);	\
 	     i = fs_find_next((dev), i + 1, state))
 
-- 
2.1.4



More information about the dev mailing list