[dpdk-dev] [PATCH 3/5] net/mlx5: fix non working secondary process by removing it

[Nélio Laranjeiro]

On Thu, Aug 17, 2017 at 03:38:22PM +0100, Ferruh Yigit wrote:
> On 8/1/2017 1:09 PM, Nelio Laranjeiro wrote:
> > Secondary process is a copy/paste of the mlx4 drivers, it was never
> > tested and it even segfault at the secondary process start in the
> > mlx5_pci_probe().
> 
> Does this means multi process support for mlx5 broken with this patch?
> If so features file and release notes should be updated if this won't be
> fixed back in this release..

No currently the secondary process in mlx5 is not working at all.  This is
only removing a non working code from the PMD.

> And what is special required for mlx5 secondary process support?

There is some work to make this secondary process work correctly, but as it
will be totally different, it does not make sense to keep a non working code
to replace it by a working one.

Concerning the release note and features, this new implementation is
expected in 17.11 same release as this patch.

> > This makes more sense to wipe this non working feature to re-write a
> > working and functional version.
> > 
> > Fixes: a48deada651b ("mlx5: allow operation in secondary processes")
> > 
> > Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro at 6wind.com>
> > Acked-by: Shahaf Shuler <shahafs at mellanox.com>
> 
> <...>

I'll update the feature documentation in a v2 to remove the "Multiprocess
aware" from the feature list in this patch.
It will be added back with the new implementation.

Thanks,

-- 
Nélio Laranjeiro
6WIND