[dpdk-dev] [PATCH] vhost: added user callbacks for socket open/close

Jens Freimann jfreimann at redhat.com
Tue Aug 22 13:58:44 CEST 2017


On Tue, Aug 22, 2017 at 09:55:19AM +0000, Stojaczyk, DariuszX wrote:
>Hi Jens,
>
>> I'm a little uncertain but my gut feeling is that in this context a connection is
>> something between two sockets, not between devices.
>
>What do you mean?
>This is a unix domain socket connection. DPDK can create the socket, then the client may connect to it via connect(2).

yes, I get that. 

>
>> I would probably add
>> these callbacks to struct vhost_user_socket. This is also where we keep the
>> list of connections.
>
>I get your point. However, it's vhost_device_ops struct that's being set by the user via rte_vhost_driver_callback_register(). The new_connection callback is there just to mark the device as *in use, can't be deleted*. It doesn't transport any connection data.

You're right, I overlooked that it needs to be set by the user. In
this case your patch is the smallest possible change and looks good to
me.

Do we need a documentation change for this?


regards,
Jens 


More information about the dev mailing list