[dpdk-dev] [PATCH] ena: fix init of ena pci_dev info

Ferruh Yigit ferruh.yigit at intel.com
Wed Aug 23 12:47:30 CEST 2017


On 8/23/2017 1:41 AM, David Harton wrote:
> eth_ena_dev_init() was not initializing all of the common
> pci dev info for the rte_eth_dev.  Added call to
> rte_eth_copy_pci_info() to complete the init particularly
> the driver name.

rte_eth_copy_pci_info() already called during probe [1], what
information was missing?

[1]
eth_ena_pci_probe()
  rte_eth_dev_pci_generic_probe()
    rte_eth_dev_pci_allocate()
      rte_eth_copy_pci_info()  <---
    eth_ena_dev_init()
      ... <--- where rte_eth_copy_pci_info() added again.

> 
> Signed-off-by: David Harton <dharton at cisco.com>
> ---
>  drivers/net/ena/ena_ethdev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
> index 80ce1f3..a6c408b 100644
> --- a/drivers/net/ena/ena_ethdev.c
> +++ b/drivers/net/ena/ena_ethdev.c
> @@ -1289,6 +1289,7 @@ static int eth_ena_dev_init(struct rte_eth_dev *eth_dev)
>  		return 0;
>  
>  	pci_dev = RTE_ETH_DEV_TO_PCI(eth_dev);
> +	rte_eth_copy_pci_info(eth_dev, pci_dev);
>  	adapter->pdev = pci_dev;
>  
>  	PMD_INIT_LOG(INFO, "Initializing %x:%x:%x.%d",
> 



More information about the dev mailing list