[dpdk-dev] [PATCH v2 3/3] net/mlx5: add hardware timestamp

[Nélio Laranjeiro]

On Thu, Aug 24, 2017 at 10:46:33AM +0300, Raslan Darawsheh wrote:
> Expose a new capapilty of Rx hw timestamp and
> added new device args to enable it hw_timestamp.
> It will add the raw hw timestamp into the packets.
> 
> Its expected that it will lower down the performance since using it
> will disable the cqe comprission, and will add extra checkes in
> the vec rx path.
> 
> Signed-off-by: Raslan Darawsheh <rasland at mellanox.com>
> ---
>  doc/guides/nics/mlx5.rst             |  5 +++++
>  drivers/net/mlx5/mlx5.c              | 23 +++++++++++++++++++++++
>  drivers/net/mlx5/mlx5.h              |  1 +
>  drivers/net/mlx5/mlx5_ethdev.c       |  3 ++-
>  drivers/net/mlx5/mlx5_rxq.c          |  3 +++
>  drivers/net/mlx5/mlx5_rxtx.c         |  5 +++++
>  drivers/net/mlx5/mlx5_rxtx.h         |  3 ++-
>  drivers/net/mlx5/mlx5_rxtx_vec_sse.c | 13 ++++++++++++-
>  8 files changed, 53 insertions(+), 3 deletions(-)
 
It is strange to enable/disable this single offload again the application
request.  Why do you need such behavior?

Another point I don't seen any code to retrieve this offloads request from the
port configuration as for the others.  It is expected in the new revision?

Thanks,

-- 
Nélio Laranjeiro
6WIND