[dpdk-dev] [PATCH 2/7] ethdev: fix port id storage

Ferruh Yigit ferruh.yigit at intel.com
Sat Dec 2 00:52:08 CET 2017


On 11/30/2017 6:29 PM, Ferruh Yigit wrote:
> port_id is now 16bits, update function parameter according.
> 
> Fixes: 4c270218aa26 ("ethdev: support security APIs")
> Cc: stable at dpdk.org
> Cc: declan.doherty at intel.com
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
> ---
> Cc: Boris Pismenny <borisp at mellanox.com>
> Cc: Aviad Yehezkel <aviadye at mellanox.com>
> Cc: Radu Nicolau <radu.nicolau at intel.com>
> Cc: Declan Doherty <declan.doherty at intel.com>
> ---

<...>

>  
>  void *
> -rte_eth_dev_get_sec_ctx(uint8_t port_id);
> +rte_eth_dev_get_sec_ctx(uint16_t port_id);

Hi Declan,

Since this is a public API, it needs API documentation. Can you please send a
patch to add doxygen comments the the API?

Thanks,
ferruh

>  
>  struct rte_eth_dev_sriov {
>  	uint8_t active;               /**< SRIOV is active with 16, 32 or 64 pools */
> 



More information about the dev mailing list