[dpdk-dev] [PATCH 10/16] net/axgbe: add transmit and receive data path apis

Ferruh Yigit ferruh.yigit at intel.com
Fri Dec 8 22:08:16 CET 2017


On 11/30/2017 5:11 AM, Ravi Kumar wrote:
> Signed-off-by: Ravi Kumar <Ravi1.kumar at amd.com>
> ---
>  drivers/net/axgbe/Makefile         |   1 +
>  drivers/net/axgbe/axgbe_ethdev.c   |  56 ++++-
>  drivers/net/axgbe/axgbe_rxtx.c     | 427 +++++++++++++++++++++++++++++++++++++
>  drivers/net/axgbe/axgbe_rxtx.h     |  19 ++
>  drivers/net/axgbe/axgbe_rxtx_vec.c | 215 +++++++++++++++++++

You may rename this as axgbe_rxtx_vec_sse.c to clarify which arch it is for.

<...>

> @@ -190,6 +192,7 @@ static const struct eth_dev_ops axgbe_eth_dev_ops = {
>  	.dev_start            = axgbe_dev_start,
>  	.dev_stop             = axgbe_dev_stop,
>  	.dev_close            = axgbe_dev_close,
> +	.link_update          = axgbe_dev_link_update,

Can you please separate this into its own patch.

<...>

> @@ -545,8 +595,8 @@ eth_axgbe_dev_init(struct rte_eth_dev *eth_dev)
>  	axgbe_set_bit(AXGBE_STOPPED, &pdata->dev_state);
>  	pdata->eth_dev = eth_dev;
>  	eth_dev->dev_ops = &axgbe_eth_dev_ops;
> -	eth_dev->rx_pkt_burst = NULL;
> -	eth_dev->tx_pkt_burst = NULL;
> +	eth_dev->rx_pkt_burst = &axgbe_recv_pkts;
> +	eth_dev->tx_pkt_burst = &axgbe_xmit_pkts_vec;

It can be helpful to comment axgbe_dev_tx_queue_setup() can set non-vector Tx path.

<...>


More information about the dev mailing list