[dpdk-dev] [PATCH] net: update licence for network headers

Hemant Agrawal hemant.agrawal at nxp.com
Mon Dec 11 06:27:41 CET 2017


On 12/8/2017 11:52 PM, Andrew Rybchenko wrote:
> On 12/08/2017 08:29 PM, Ferruh Yigit wrote:
>> On 12/8/2017 2:28 AM, Olivier Matz wrote:
>>> To be compliant with the DPDK licensing guidelines, switch to
>>> BSD-3-Clause. It can be done safely since the BSD headers from which
>>> these files derive also exist as a BSD-3-Clause license in FreeBSD.
>>>
>>> Link:
>>> https://raw.githubusercontent.com/freebsd/freebsd/78a6b0861813af31e1354fa407c5701e8764b4d6/sys/netinet/ip_icmp.h
>>>
>>> Link:
>>> https://raw.githubusercontent.com/freebsd/freebsd/78a6b0861813af31e1354fa407c5701e8764b4d6/sys/netinet/ip.h
>>>
>>> Link:
>>> https://raw.githubusercontent.com/freebsd/freebsd/78a6b0861813af31e1354fa407c5701e8764b4d6/sys/netinet/sctp.h
>>>
>>> Link:
>>> https://raw.githubusercontent.com/freebsd/freebsd/78a6b0861813af31e1354fa407c5701e8764b4d6/sys/netinet/tcp.h
>>>
>>> Link:
>>> https://raw.githubusercontent.com/freebsd/freebsd/78a6b0861813af31e1354fa407c5701e8764b4d6/sys/netinet/udp.h
>>>
>>> Signed-off-by: Olivier Matz <olivier.matz at 6wind.com>
>> <...>
>>
>>> + * SPDX-License-Identifier: BSD-3-Clause
>>>    *
>>> - *      @(#)in.h        8.3 (Berkeley) 1/3/94
>>> - * $FreeBSD: src/sys/netinet/in.h,v 1.82 2003/10/25 09:37:10 ume Exp $
>>> + * Copyright(c) 1982, 1986, 1990, 1993
>>> + *      The Regents of the University of California.
>>> + * Copyright(c) 2013 6WIND S.A.
>>> + * All rights reserved.
>>>    */
>> Not sure how much it matters but in the document Hemant put, order is
>> different,
>> it starts with Copyright line instead of SPDX line:
>>
>> "
>> Copyright (C) [YEAR] NAME-OF-COPYRIGHT-HOLDER
>> SPDX-License-Identifier:        BSD-3-Clause
>> "
>>
>> So I assume for multiple Copyright holder:
>>
>> "
>> Copyright (C) [YEAR] NAME-OF-COPYRIGHT-HOLDER
>> Copyright (C) [YEAR] NAME-OF-COPYRIGHT-HOLDER-2
>> Copyright (C) [YEAR] NAME-OF-COPYRIGHT-HOLDER-3
>> SPDX-License-Identifier:        BSD-3-Clause
>> "
>>
>> And do we still need "All rights reserved." ?
>>
>>
>> I am for following same syntax in all files (whichever is chosen),
>> this may
>> helps us in the future for scripting licensing checks.
>>
>> <...>
>
> License text example in [1] starts from Copyright and has All rights
> reserved.
> I agree that template should be clearly specified from the very beginning.
>
> [1] https://spdx.org/licenses/BSD-3-Clause#licenseText
>
Hi all,
	Most templates are showing copyright first and SPDX later i.e. the 
typical way for writing the license.

However some projects has followed it other way around to make it easy 
for tools i.e. the TOP line.

I agree with Ferruh that we shall follow single convention.  I will 
prefer to do it in following way to make it consistent. (I will also fix 
my change patches).

 >> Copyright (C) [YEAR] NAME-OF-COPYRIGHT-HOLDER
 >> Copyright (C) [YEAR] NAME-OF-COPYRIGHT-HOLDER-2
 >> Copyright (C) [YEAR] NAME-OF-COPYRIGHT-HOLDER-3
 >> SPDX-License-Identifier:        BSD-3-Clause


Regards,
Hemant




More information about the dev mailing list