[dpdk-dev] [PATCH v2 2/2] examples/ipsec-secgw: add target queues in flow actions
Nelio Laranjeiro
nelio.laranjeiro at 6wind.com
Mon Dec 11 09:21:32 CET 2017
Hi Anoob,
On Fri, Dec 08, 2017 at 10:10:28PM +0530, Anoob Joseph wrote:
> HI Nelio,
>
>
> On 08-12-2017 20:10, Nelio Laranjeiro wrote:
> > On Fri, Dec 08, 2017 at 07:30:03PM +0530, Anoob wrote:
> > > Hi Nelio,
> > >
> > >
> > [...]
> > > > + goto flow_create;
> > > > + /* Try Queue. */
> > > > + for (i = 0;
> > > > + i < eth_dev->data->nb_rx_queues; ++i)
> > > > + if (eth_dev->data->rx_queues[i])
> > > > + break;
> > > Is the following check correct?
> > [...]
> >
> > For an application, it seems not necessary. The application knows which
> > queues are configured in the drivers has it has made the configuration.
> >
> > Removing it in the v3.
> I think you misunderstood me here.
Indeed, I misunderstood,
> I was talking about the following line.
>
> + if (i != eth_dev->data->nb_rx_queues)
> + return -1;
>
> Shouldn't it be?
>
> + if (i == eth_dev->data->nb_rx_queues)
> + return -1;
Yes it should.
Anyway, I don't thing it is necessary to keep this check, from what I
saw in the application source code, it initialise all Rx queues up to
nb_rx_queues without leaving any hole.
According to this, I'll just remove this verification, is it okay for
you?
Thanks,
--
Nélio Laranjeiro
6WIND
More information about the dev
mailing list