[dpdk-dev] [PATCH 01/11] cryptodev: add compile support for AMD CCP crypto PMD

Kumar, Ravi1 Ravi1.Kumar at amd.com
Mon Dec 11 14:41:50 CET 2017


>Hi Ravi,
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ravi Kumar
>> Sent: Thursday, November 30, 2017 1:12 PM
>> To: dev at dpdk.org
>> Subject: [dpdk-dev] [PATCH 01/11] cryptodev: add compile support for 
>> AMD CCP crypto PMD
>> 
>
>Thanks for splitting the original patch into multiple ones.
>However, in this case, this should get merged to the other patches, as all the changes are referencing files/folders that do not exist yet.
>
>Apart from this, two comments below.
>
>Thanks,
>Pablo
>
>> Signed-off-by: Ravi Kumar <Ravi1.kumar at amd.com>
>> ---
>>  MAINTAINERS             | 6 ++++++
>>  config/common_base      | 5 +++++
>>  drivers/crypto/Makefile | 1 +
>>  mk/rte.app.mk           | 2 ++
>>  4 files changed, 14 insertions(+)
>> 
>> diff --git a/MAINTAINERS b/MAINTAINERS index f0baeb4..daac82e 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -588,6 +588,12 @@ M: Pablo de Lara
>> <pablo.de.lara.guarch at intel.com>
>>  T: git://dpdk.org/next/dpdk-next-crypto
>>  F: doc/guides/cryptodevs/features/default.ini
>> 
>> +AMD CCP Crypto PMD
>
>Remove trailing whitespace here.
>
>> +M: Ravi Kumar <ravi1.kumar at amd.com>
>> +F: drivers/crypto/ccp/
>> +F: doc/guides/cryptodevs/ccp.rst
>> +F: doc/guides/cryptodevs/features/ccp.ini
>
>Add these lines, as you add the files.
>
>> +
>
>
Hi Pablo,

Thanks for the review comments. Will work on it.

Regards,
Ravi


More information about the dev mailing list