[dpdk-dev] [PATCH v2 01/18] eal: prepend busname on legacy device declaration
Shreyansh Jain
shreyansh.jain at nxp.com
Mon Dec 11 14:57:17 CET 2017
One very quick comment:
On Thursday 12 October 2017 01:51 PM, Gaetan Rivet wrote:
> Legacy device options (-b, -w, --vdev) need to prepend their bus name to
> user parameters for backward compatibility.
>
> Signed-off-by: Gaetan Rivet <gaetan.rivet at 6wind.com>
> ---
> lib/librte_eal/common/eal_common_options.c | 17 ++++++++++++-----
> 1 file changed, 12 insertions(+), 5 deletions(-)
>
> diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c
> index 630c9d2..d57cb5d 100644
> --- a/lib/librte_eal/common/eal_common_options.c
> +++ b/lib/librte_eal/common/eal_common_options.c
> @@ -143,13 +143,16 @@ static int mem_parsed;
> static int core_parsed;
>
> static int
> -eal_option_device_add(enum rte_devtype type, const char *optarg)
> +eal_option_device_add(enum rte_devtype type,
> + const char *busname, const char *optarg)
> {
> struct device_option *devopt;
> size_t optlen;
> int ret;
>
> optlen = strlen(optarg) + 1;
> + if (busname != NULL)
> + optlen += strlen(optarg) + 1;
I think you want "optlen += strlen(busname) + 1";
> devopt = calloc(1, sizeof(*devopt) + optlen);
> if (devopt == NULL) {
> RTE_LOG(ERR, EAL, "Unable to allocate device option\n");
[...]
More information about the dev
mailing list