[dpdk-dev] [PATCH 3/3] doc: update documentation for flow classify lib

Singh, Jasvinder jasvinder.singh at intel.com
Mon Dec 11 16:53:19 CET 2017



> -----Original Message-----
> From: Mcnamara, John
> Sent: Monday, December 11, 2017 2:55 PM
> To: Singh, Jasvinder <jasvinder.singh at intel.com>; dev at dpdk.org
> Cc: Iremonger, Bernard <bernard.iremonger at intel.com>
> Subject: RE: [dpdk-dev] [PATCH 3/3] doc: update documentation for flow
> classify lib
> 
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jasvinder Singh
> > Sent: Thursday, November 23, 2017 11:32 AM
> > To: dev at dpdk.org
> > Cc: Iremonger, Bernard <bernard.iremonger at intel.com>
> > Subject: [dpdk-dev] [PATCH 3/3] doc: update documentation for flow
> > classify lib
> >
> > Updates the documentation for flow classification library and sample
> > application.
> >
> > Signed-off-by: Jasvinder Singh <jasvinder.singh at intel.com>
> 
> 
> >
> > +370,24 @@ parses the Flow rule.
> >
> >      struct rte_flow_classify {
> >          uint32_t id;  /* unique ID of classify object */
> > -        struct rte_flow_action action; /* action when match found */
> > -	struct classify_rules rules; /* union of rules */
> > +        enum rte_flow_classify_table_type tbl_type; /* rule table */
> > +        struct classify_rules rules; /* union of rules */
> >          union {
> >              struct acl_keys key;
> >          } u;
> >          int key_found; /* rule key found in table */
> > -        void *entry; /* pointer to buffer to hold rule meta data */
> > -        void *entry_ptr; /* handle to the table entry for rule meta data
> > */
> > +        struct rte_flow_classify_table_entry entry;  /* rule meta data */
> > +       void *entry_ptr; /* handle to the table entry for rule meta
> > + data
> 
> 
> The last line here is indented less than the others. Also there is a stray tab a
> few lines above it (in the existing text). Can you replace that as well.
> 

Will fix this in the next version. Thank you.

Jasvinder


More information about the dev mailing list